Conversation
|
Any progress on that? |
|
Can you show benchmarks here? |
|
Sorry, I did not save it
…On Tue, Sep 6, 2022, 3:58 AM Ofek Lev ***@***.***> wrote:
Can you show benchmarks here?
—
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARGSBY6EZYPTMMP35OPC4LV42JJ3ANCNFSM573P7LQA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Then how can one determine whether or not to accept this PR? |
|
Well it's up to a reviewer to make any tests they want or need
…On Tue, Sep 6, 2022, 7:17 AM Ofek Lev ***@***.***> wrote:
Then how can one determine whether or not to accept this PR?
—
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARGSB3U2K4IWNXK7QLAPO3V43AVNANCNFSM573P7LQA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hi @excitoon, do you have a benchmark comparing the change to the original? |
|
Yes, I had. I ran it on ClickHouse source code with all submodules
recursively synced. It showed about 5% improvement.
But you have to reproduce it yourself to be 100% sure
…On Thu, Sep 8, 2022, 5:27 AM Caleb P. Burns ***@***.***> wrote:
Hi @excitoon <https://github.com/excitoon>, do you have a benchmark
comparing the change to the original?
—
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARGSB4CR3ZM3M3NEHSCXILV5FFJXANCNFSM573P7LQA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@excitoon I now have benchmarking setup in a dev branch, and I plan on comparing this change. |
|
Nice, good to see you again Caleb! I'm not sure if you're aware but every Python package built with Hatchling (now the default recommendation) relies on your project. If you look at the download badge (only represents PyPI traffic) you can get a small sense of the scale 😄 |
|
@ofek I knew Hatchling depended on this project but I wasn't aware hatchling is now the default recommendation. That's a lot of downloads! |
|
Nothing compared to yours! |
|
After benchmarking and testing this specific change, this will not work because it breaks edge-cases from Issue #41 (tests This change appears to be 15% slower than the current approach in Python 3.14 when benchmarked against Python's source tree. |
3 participants
Progress on #38